core/validatorapi: fix readyz issue

[dB2510]

Fixes readyz issue. This is done by moving seenPubkeys logic to getPubShareFunc. In canary clusters such as canary-goerli-1 it turns out that the nodes reporting value 5 are the ones with lighthouse VC which calls get_validator with validator_index and not pubkey.

category: bug
ticket: #1501

[codecov]

Codecov Report

Base: 54.17% // Head: 54.05% // Decreases project coverage by -0.12% ⚠️

Coverage data is based on head (2d3d29b) compared to base (3c1ce29).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1599      +/-   ##
==========================================
- Coverage   54.17%   54.05%   -0.13%     
==========================================
  Files         157      157              
  Lines       19943    19942       -1     
==========================================
- Hits        10804    10779      -25     
- Misses       7679     7709      +30     
+ Partials     1460     1454       -6     

Impacted Files	Coverage Δ
core/validatorapi/validatorapi.go	59.00% <0.00%> (-0.06%)	⬇️
core/qbft/qbft.go	73.73% <0.00%> (-9.25%)	⬇️
p2p/bootnode.go	20.53% <0.00%> (-2.68%)	⬇️
core/priority/prioritiser.go	60.48% <0.00%> (-0.41%)	⬇️
app/eth2wrap/synthproposer.go	66.56% <0.00%> (+0.31%)	⬆️
app/peerinfo/peerinfo.go	54.71% <0.00%> (+3.14%)	⬆️
app/vmock.go	77.20% <0.00%> (+5.69%)	⬆️
dkg/transport.go	66.66% <0.00%> (+12.96%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.