Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/aggsigdb: delete expired duties and queries #1598

Merged
merged 2 commits into from
Jan 9, 2023

Conversation

corverroos
Copy link
Contributor

Delete expired data in aggsigdb when duty expires. Also delete abandoned queries to avoid memory leaks.

category: feature
ticket: #1582

@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Base: 54.14% // Head: 54.07% // Decreases project coverage by -0.07% ⚠️

Coverage data is based on head (74b1bb1) compared to base (d7760ca).
Patch coverage: 87.50% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1598      +/-   ##
==========================================
- Coverage   54.14%   54.07%   -0.08%     
==========================================
  Files         157      156       -1     
  Lines       19916    19963      +47     
==========================================
+ Hits        10784    10795      +11     
- Misses       7678     7712      +34     
- Partials     1454     1456       +2     
Impacted Files Coverage Δ
core/aggsigdb/memory.go 81.48% <87.09%> (+0.92%) ⬆️
app/app.go 64.33% <100.00%> (+0.69%) ⬆️
core/qbft/qbft.go 73.31% <0.00%> (-10.51%) ⬇️
core/priority/prioritiser.go 60.48% <0.00%> (-1.62%) ⬇️
app/metrics.go 100.00% <0.00%> (ø)
core/scheduler/scheduler.go 72.79% <0.00%> (+0.26%) ⬆️
app/monitoringapi.go 81.45% <0.00%> (+1.45%) ⬆️
app/vmock.go 77.72% <0.00%> (+5.18%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@corverroos corverroos added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jan 9, 2023
@obol-bulldozer obol-bulldozer bot merged commit 0a3f5c5 into main Jan 9, 2023
@obol-bulldozer obol-bulldozer bot deleted the corver/addsigleak branch January 9, 2023 10:56
xenowits pushed a commit that referenced this pull request Jan 9, 2023
Delete expired data in aggsigdb when duty expires. Also delete abandoned queries to avoid memory leaks.

category: feature 
ticket: #1582
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants