core/consensus: fix wire compatibility #1556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corverroos
commented
Dec 14, 2022
| @@ -13,14 +13,28 @@ message QBFTMsg { | |||
| core.corepb.v1.Duty duty = 2; | |||
| int64 peer_idx = 3; | |||
| int64 round = 4; | |||
| reserved 5; // Deprecated value | |||
| core.corepb.v1.UnsignedDataSet value_legacy = 5 [deprecated = true]; // Prefer value. | |||
There was a problem hiding this comment.
these fields need to be here, since they are included when calculating signature hashes. Removing them results in server and client calculating different hashes.
corverroos
added
the
merge when ready
Codecov ReportBase: 54.43% // Head: 54.39% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1556 +/- ##
==========================================
- Coverage 54.43% 54.39% -0.04%
==========================================
Files 153 153
Lines 19421 19421
==========================================
- Hits 10572 10565 -7
- Misses 7427 7432 +5
- Partials 1422 1424 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
dB2510
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts "reserved" fields since they are required to calculate correct hash when verifying signatures. Instead just stop using fields.
category: bug
ticket: #1555