app/eth2wrap: query previous block for synthetic proposals #1533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 54.18% // Head: 54.01% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1533 +/- ##
==========================================
- Coverage 54.18% 54.01% -0.17%
==========================================
Files 150 150
Lines 19135 19232 +97
==========================================
+ Hits 10368 10388 +20
- Misses 7358 7427 +69
- Partials 1409 1417 +8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
xenowits
reviewed
Dec 9, 2022
Comment on lines
+164
to
+166
| }, | ||
| nil, | ||
| ) |
There was a problem hiding this comment.
Suggested change
| }, | |
| nil, | |
| ) | |
| }, nil) |
There was a problem hiding this comment.
oh, it's auto-generated i think
xenowits
reviewed
Dec 9, 2022
| block, err := h.syntheticBlock(ctx, slot) | ||
| if err != nil { | ||
| return nil, err | ||
| } else if block.Version != spec.DataVersionBellatrix { |
There was a problem hiding this comment.
shouldn't this be for fork versions >= bellatrix? Ex: Capella
There was a problem hiding this comment.
go-eth2 only supports bellatrix blinded blocks at this point
corverroos
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Query previous blocks to propose as synthetic blocks since only proposers can query the block_proposal endpoint.
category: bug
ticket: #1486