Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: update workflows to go1.19.3 #1481

Merged
merged 4 commits into from
Nov 24, 2022
Merged

github: update workflows to go1.19.3 #1481

merged 4 commits into from
Nov 24, 2022

Conversation

xenowits
Copy link
Contributor

Updates github workflows to go1.19.3

category: misc
ticket: #1366

@xenowits xenowits self-assigned this Nov 24, 2022
@xenowits xenowits marked this pull request as draft November 24, 2022 07:27
@codecov
Copy link

codecov bot commented Nov 24, 2022

Codecov Report

Base: 53.92% // Head: 53.90% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (de756bb) compared to base (849900a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1481      +/-   ##
==========================================
- Coverage   53.92%   53.90%   -0.02%     
==========================================
  Files         148      148              
  Lines       18774    18775       +1     
==========================================
- Hits        10124    10121       -3     
- Misses       7267     7270       +3     
- Partials     1383     1384       +1     
Impacted Files Coverage Δ
app/vmock.go 71.50% <0.00%> (-2.60%) ⬇️
app/app.go 61.99% <0.00%> (-1.16%) ⬇️
core/dutydb/memory.go 69.28% <0.00%> (+0.69%) ⬆️
app/eth2wrap/httpwrap.go 21.90% <0.00%> (+0.75%) ⬆️
core/qbft/qbft.go 82.46% <0.00%> (+0.83%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@xenowits xenowits marked this pull request as ready for review November 24, 2022 07:48
Copy link
Contributor

@corverroos corverroos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update go.mod as well I think and check-go-version pre-commit

@xenowits
Copy link
Contributor Author

We can't update go version to a patch release in go.mod. Ref: https://go.dev/ref/mod#go-mod-file-go

Screenshot 2022-11-24 at 1 46 26 PM

@corverroos
Copy link
Contributor

@xenowits we also need to upgrade the Dockerfile so the built binaries actually use the new version:

FROM golang:1.19-alpine AS builder

@xenowits xenowits added the merge when ready Indicates bulldozer bot may merge when all checks pass label Nov 24, 2022
@obol-bulldozer obol-bulldozer bot merged commit b17e515 into main Nov 24, 2022
@obol-bulldozer obol-bulldozer bot deleted the xenowits/go1.19.3 branch November 24, 2022 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants