Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p2p: retry send once on relay errors #1465

Merged
merged 1 commit into from
Nov 21, 2022
Merged

Conversation

corverroos
Copy link
Contributor

Retry sends once on relay errors. This should solve 99% of the stream reset warnings of infosync and peerinfo protocols when using relay connections. This only now became an issue since these protocols do send-receive (other protocols did send and receive separately).

category: bug
ticket: none

@codecov
Copy link

codecov bot commented Nov 20, 2022

Codecov Report

Base: 53.54% // Head: 54.06% // Increases project coverage by +0.51% 🎉

Coverage data is based on head (dfe74ed) compared to base (0f229c9).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1465      +/-   ##
==========================================
+ Coverage   53.54%   54.06%   +0.51%     
==========================================
  Files         147      147              
  Lines       18673    18683      +10     
==========================================
+ Hits         9999    10101     +102     
+ Misses       7297     7210      -87     
+ Partials     1377     1372       -5     
Impacted Files Coverage Δ
p2p/sender.go 71.84% <100.00%> (+28.83%) ⬆️
app/app.go 62.69% <0.00%> (+0.76%) ⬆️
core/priority/prioritiser.go 62.55% <0.00%> (+1.23%) ⬆️
app/vmock.go 75.64% <0.00%> (+1.55%) ⬆️
p2p/ping.go 2.18% <0.00%> (+2.18%) ⬆️
core/qbft/qbft.go 82.46% <0.00%> (+10.02%) ⬆️
dkg/transport.go 66.66% <0.00%> (+12.96%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@corverroos corverroos added the merge when ready Indicates bulldozer bot may merge when all checks pass label Nov 21, 2022
@obol-bulldozer obol-bulldozer bot merged commit e7cbb56 into main Nov 21, 2022
@obol-bulldozer obol-bulldozer bot deleted the corver/retryonreset branch November 21, 2022 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants