app/log: integrate optional loki logging spout #1425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 53.51% // Head: 53.26% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1425 +/- ##
==========================================
- Coverage 53.51% 53.26% -0.26%
==========================================
Files 147 148 +1
Lines 18316 18390 +74
==========================================
- Hits 9802 9795 -7
- Misses 7171 7247 +76
- Partials 1343 1348 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
corverroos
force-pushed
the
corver/lokiadd
branch
from
4842d07
to
8f465e3
Compare
xenowits
reviewed
Nov 11, 2022
dB2510
approved these changes
Nov 11, 2022
app/log/config.go
Outdated
| // logger is the global logger. | ||
| logger zapLogger = newDefaultLogger() | ||
| // stopFuncs are the global logger stop functions. | ||
| stopFuncs []func(context.Context) = nil |
There was a problem hiding this comment.
why do you need to initialize this as nil?
xenowits
reviewed
Nov 11, 2022
xenowits
approved these changes
Nov 11, 2022
Co-authored-by: Abhishek Kumar <[email protected]>
corverroos
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an optional loki-client as log destination for local docker-compose deployments.
category: feature
ticket: #1406