testutil/beaconmock: add head producer #1308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 53.45% // Head: 53.44% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1308 +/- ##
==========================================
- Coverage 53.45% 53.44% -0.01%
==========================================
Files 141 142 +1
Lines 16944 16919 -25
==========================================
- Hits 9058 9043 -15
+ Misses 6608 6602 -6
+ Partials 1278 1274 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
xenowits
reviewed
Oct 18, 2022
testutil/beaconmock/blockproducer.go
Outdated
| return &BlockProducer{server: server} | ||
| } | ||
|
|
||
| // BlockProducer is stateful structure for providing deterministic block roots based on slot events. |
There was a problem hiding this comment.
Suggested change
| // BlockProducer is stateful structure for providing deterministic block roots based on slot events. | |
| // BlockProducer is a stateful struct for providing deterministic block roots based on slot events. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
dB2510
changed the title
corverroos
approved these changes
Oct 19, 2022
testutil/beaconmock/options.go
Outdated
| mock.overrides = append(mock.overrides, staticOverride{ | ||
| Endpoint: "/eth/v1/config/spec", | ||
| Key: "EPOCHS_PER_SYNC_COMMITTEE_PERIOD", | ||
| Value: "2", |
testutil/validatormock/synccomm.go
Outdated
| return err | ||
| } | ||
|
|
||
| log.Info(ctx, "Mock sync committee msg submitted", z.Int("slot", int(slot)), z.Str("root", hex.EncodeToString(blockRoot[:]))) |
There was a problem hiding this comment.
remove root, it isn't human understandable
dB2510
force-pushed
the
dhruv/blockproducer
branch
from
bfee61c
to
7145ba5
Compare
dB2510
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds head producer to beaconmock.
category: feature
ticket: #1307