Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/parsigex: add support for DutySyncMessage #1241

Merged
merged 2 commits into from
Oct 8, 2022

Conversation

xenowits
Copy link
Contributor

@xenowits xenowits commented Oct 8, 2022

Add support for DutySyncMessage to parsigex. Also add tests.

category: feature
ticket: #1191

@codecov
Copy link

codecov bot commented Oct 8, 2022

Codecov Report

Base: 53.27% // Head: 53.53% // Increases project coverage by +0.25% 🎉

Coverage data is based on head (71c3557) compared to base (4cbdd48).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1241      +/-   ##
==========================================
+ Coverage   53.27%   53.53%   +0.25%     
==========================================
  Files         139      139              
  Lines       16139    16145       +6     
==========================================
+ Hits         8598     8643      +45     
+ Misses       6295     6254      -41     
- Partials     1246     1248       +2     
Impacted Files Coverage Δ
core/signeddata.go 40.34% <ø> (ø)
core/parsigex/parsigex.go 58.99% <100.00%> (+1.84%) ⬆️
p2p/bootnode.go 20.53% <0.00%> (-2.68%) ⬇️
core/scheduler/scheduler.go 73.13% <0.00%> (-0.54%) ⬇️
app/vmock.go 71.89% <0.00%> (ø)
core/qbft/qbft.go 81.11% <0.00%> (+9.44%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@xenowits xenowits self-assigned this Oct 8, 2022
@xenowits xenowits added the merge when ready Indicates bulldozer bot may merge when all checks pass label Oct 8, 2022
@obol-bulldozer obol-bulldozer bot merged commit fa1335b into main Oct 8, 2022
@obol-bulldozer obol-bulldozer bot deleted the xenowits/sync-msg-parsigex branch October 8, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants