Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: fix lint #1228

Merged
merged 1 commit into from
Oct 5, 2022
Merged

cluster: fix lint #1228

merged 1 commit into from
Oct 5, 2022

Conversation

dB2510
Copy link
Contributor

@dB2510 dB2510 commented Oct 5, 2022

Fixes golangci-lint on main.

category: fixbuild
ticket: none

@dB2510 dB2510 added the merge when ready Indicates bulldozer bot may merge when all checks pass label Oct 5, 2022
@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Base: 52.91% // Head: 53.21% // Increases project coverage by +0.30% 🎉

Coverage data is based on head (c93297b) compared to base (328cb6e).
Patch coverage: 16.66% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1228      +/-   ##
==========================================
+ Coverage   52.91%   53.21%   +0.30%     
==========================================
  Files         136      136              
  Lines       15987    15987              
==========================================
+ Hits         8460     8508      +48     
+ Misses       6283     6235      -48     
  Partials     1244     1244              
Impacted Files Coverage Δ
cluster/definition.go 59.10% <16.66%> (ø)
app/vmock.go 71.89% <0.00%> (ø)
core/leadercast/transport.go 76.33% <0.00%> (+1.18%) ⬆️
core/qbft/qbft.go 81.54% <0.00%> (+9.87%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@obol-bulldozer obol-bulldozer bot merged commit 50e2461 into main Oct 5, 2022
@obol-bulldozer obol-bulldozer bot deleted the dhruv/fixlintcluster branch October 5, 2022 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants