core: add signed and unsigned types for sync duties #1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 53.33% // Head: 52.83% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1202 +/- ##
==========================================
- Coverage 53.33% 52.83% -0.51%
==========================================
Files 133 133
Lines 15505 15648 +143
==========================================
- Hits 8269 8267 -2
- Misses 6045 6185 +140
- Partials 1191 1196 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
xenowits
approved these changes
Sep 30, 2022
Comment on lines
+555
to
+557
| size := 128 | ||
| index := rand.Intn(size) | ||
| resp := bitfield.NewBitvector128() |
There was a problem hiding this comment.
Suggested change
| size := 128 | |
| index := rand.Intn(size) | |
| resp := bitfield.NewBitvector128() | |
| var ( | |
| size = 128 | |
| index = rand.Intn(size) | |
| resp = bitfield.NewBitvector128() | |
| ) |
testutil/random.go
Outdated
| return &altair.SyncCommitteeContribution{ | ||
| Slot: RandomSlot(), | ||
| BeaconBlockRoot: RandomRoot(), | ||
| SubcommitteeIndex: 0, |
testutil/random.go
Outdated
|
|
||
| func RandomSyncContributionAndProof() *altair.ContributionAndProof { | ||
| return &altair.ContributionAndProof{ | ||
| AggregatorIndex: 0, |
There was a problem hiding this comment.
why not a random index? Like
AggregatorIndex: rand.Uint64()
dB2510
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds signed and unsigned types for sync committee duties.
category: feature
ticket: #1177