core: improve logging #1187
core: improve logging #1187
Conversation
Codecov ReportBase: 53.41% // Head: 53.41% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1187 +/- ##
=======================================
Coverage 53.41% 53.41%
=======================================
Files 133 133
Lines 15509 15504 -5
=======================================
- Hits 8284 8282 -2
+ Misses 6036 6035 -1
+ Partials 1189 1187 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| @@ -169,7 +169,7 @@ func (f *Fetcher) fetchAggregatorData(ctx context.Context, slot int64, defSet co | |||
|
|
|||
| // This validator isn't an aggregator for this slot. | |||
| if !res.IsAggregator { | |||
| log.Debug(ctx, "Not selected for attester aggregation duty", z.Any("pubkey", pubkey)) | |||
| log.Debug(ctx, "Attester not selected for aggregation duty", z.Any("pubkey", pubkey)) | |||
There was a problem hiding this comment.
maybe "Validator not selected for aggregation duty"
There was a problem hiding this comment.
The validator is an attester at this point.
| @@ -188,7 +186,7 @@ func (b Broadcaster) Broadcast(ctx context.Context, duty core.Duty, pubkey core. | |||
|
|
|||
| err = b.eth2Cl.SubmitAggregateAttestations(ctx, []*eth2p0.SignedAggregateAndProof{&aggAndProof.SignedAggregateAndProof}) | |||
| if err == nil { | |||
| log.Info(ctx, "Attestation aggregation successfully submitted to beacon node", | |||
| log.Info(ctx, "Successfully submitted attestation aggregation to beacon node", | |||
There was a problem hiding this comment.
maybe "Successfully submitted aggregated attestation to beacon node"
There was a problem hiding this comment.
potato potato 😉
| @@ -91,14 +91,14 @@ func (db *MemDB) StoreExternal(ctx context.Context, duty core.Duty, signedSet co | |||
| if err != nil { | |||
| return err | |||
| } else if !ok { | |||
| log.Debug(ctx, "Not storing duplicate partial signed data", | |||
| z.Any("pubkey", pubkey), z.Int("share_idx", sig.ShareIdx)) | |||
| log.Debug(ctx, "Partial signed data ignored since duplicate") | |||
There was a problem hiding this comment.
maybe "Duplicate partial signed data ignored"
There was a problem hiding this comment.
I'm using identical prefixes
corverroos
added
the
merge when ready
Use common prefix for all logging of each component:
Also:
category: misc
ticket: none