core/fetcher: support aggregate attestation not found #1184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 53.09% // Head: 53.38% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1184 +/- ##
==========================================
+ Coverage 53.09% 53.38% +0.28%
==========================================
Files 133 133
Lines 15492 15509 +17
==========================================
+ Hits 8226 8280 +54
+ Misses 6078 6039 -39
- Partials 1188 1190 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
xenowits
reviewed
Sep 28, 2022
xenowits
reviewed
Sep 28, 2022
xenowits
approved these changes
Sep 28, 2022
Co-authored-by: Abhishek Kumar <[email protected]>
corverroos
commented
Sep 28, 2022
| @@ -72,9 +76,6 @@ func httpPost(ctx context.Context, base string, endpoint string, body io.Reader) | |||
| return nil, errors.Wrap(err, "invalid endpoint") | |||
| } | |||
|
|
|||
| ctx, cancel := context.WithTimeout(ctx, time.Second*2) // TODO(dhruv): use actual configured timeout. | |||
corverroos
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes panic in fetcher when
AggregateAttestationisn't found and go-eth2-client returnsnil,nil. This can happen when using infura and theSubmitBeaconCommitteeSubscriptionwas processed by a different node. Just retry in that case.Also use proper timeout for eth2exp calls (2s is too short).
category: bug
ticket: none