app: add aggregation integration test #1150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xenowits
reviewed
Sep 22, 2022
testutil/validatormock/attest.go
Outdated
|
|
||
| return nil | ||
| } | ||
|
|
||
| // Aggregate should be called at latest 2/3 into the slot, it does slot attestation aggregations. | ||
| func (a *SlotAttester) Aggregate(ctx context.Context) error { | ||
| s := a.slot | ||
| // Wait for Prepare and Attest to complete | ||
| <-a.selectinsOK |
There was a problem hiding this comment.
Suggested change
| <-a.selectinsOK | |
| <-a.selectionsOK |
Codecov ReportBase: 53.12% // Head: 52.92% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1150 +/- ##
==========================================
- Coverage 53.12% 52.92% -0.20%
==========================================
Files 130 131 +1
Lines 15207 15266 +59
==========================================
+ Hits 8078 8079 +1
- Misses 5961 6023 +62
+ Partials 1168 1164 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
dB2510
approved these changes
Sep 22, 2022
| datas datas | ||
| dutiesOK chan struct{} | ||
| selectionsOK chan struct{} | ||
| datasOK chan struct{} |
There was a problem hiding this comment.
why do we need these channels?
There was a problem hiding this comment.
what was the problem in the absence of these channels?
There was a problem hiding this comment.
It solves concurrency problems.
- SlotAttester does not worry about concurrency
- Prepare, Attest and Aggregate can be called concurrently, especially in testing where slots are only 1s duration.
- But Attest requires data from Prepare
- And Aggregate requires data from Prepare and Attest
- So these channels allow the Attest and Aggregate gorountines to wait for their data to be available.
xenowits
approved these changes
Sep 22, 2022
corverroos
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds assertion of aggregations in attestation integration tests.
Also:
testutil. RequireNoErrorfor improved debugging in testscategory: test
ticket: #1069