Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: fix issue with k1 signature verification #1147

Merged
merged 5 commits into from
Sep 23, 2022

Conversation

HananINouman
Copy link
Contributor

@HananINouman HananINouman commented Sep 21, 2022

Fix k1 signature verification by adding support for yellow paper recovery id. Edit cluster tests.

category: bug
ticket: #1149

@xenowits xenowits changed the title fix enr and configHash sigs cluster: fix enr and config hash sigs Sep 21, 2022
@codecov
Copy link

codecov bot commented Sep 23, 2022

Codecov Report

Base: 53.12% // Head: 52.91% // Decreases project coverage by -0.20% ⚠️

Coverage data is based on head (2341c08) compared to base (14e6f80).
Patch coverage: 0.00% of modified lines in pull request are covered.

❗ Current head 2341c08 differs from pull request most recent head 872aef9. Consider uploading reports for the commit 872aef9 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1147      +/-   ##
==========================================
- Coverage   53.12%   52.91%   -0.21%     
==========================================
  Files         130      131       +1     
  Lines       15207    15278      +71     
==========================================
+ Hits         8078     8084       +6     
- Misses       5961     6021      +60     
- Partials     1168     1173       +5     
Impacted Files Coverage Δ
cluster/helpers.go 60.13% <0.00%> (-3.76%) ⬇️
core/qbft/qbft.go 71.67% <0.00%> (-10.31%) ⬇️
testutil/beaconmock/options.go 33.33% <0.00%> (-2.78%) ⬇️
app/app.go 58.01% <0.00%> (-1.53%) ⬇️
core/bcast/bcast.go 53.84% <0.00%> (-0.77%) ⬇️
core/scheduler/scheduler.go 73.31% <0.00%> (-0.54%) ⬇️
testutil/beaconmock/server.go 54.47% <0.00%> (-0.45%) ⬇️
dkg/dkg.go 49.44% <0.00%> (-0.12%) ⬇️
dkg/disk.go 52.23% <0.00%> (-0.07%) ⬇️
testutil/beaconmock/attestation.go 82.60% <0.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@xenowits xenowits marked this pull request as ready for review September 23, 2022 04:58
@corverroos corverroos changed the title cluster: fix enr and config hash sigs cluster: fix issue with k1 signature verification Sep 23, 2022
Copy link
Contributor

@corverroos corverroos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, well done on your first charon PR! 🚀 💪

testutil/random.go Outdated Show resolved Hide resolved
Copy link
Contributor

@dB2510 dB2510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

cluster/helpers.go Outdated Show resolved Hide resolved
@xenowits xenowits added the merge when ready Indicates bulldozer bot may merge when all checks pass label Sep 23, 2022
@obol-bulldozer obol-bulldozer bot merged commit 431e1b4 into main Sep 23, 2022
@obol-bulldozer obol-bulldozer bot deleted the Hanan/fix-signatures branch September 23, 2022 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants