core/fetcher: add support for DutyAggregator
#1118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1118 +/- ##
==========================================
- Coverage 53.06% 53.06% -0.01%
==========================================
Files 128 128
Lines 14626 14683 +57
==========================================
+ Hits 7762 7792 +30
- Misses 5748 5773 +25
- Partials 1116 1118 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
xenowits
force-pushed
the
xenowits/fetcher-duty-aggregator
branch
from
10f4b7a
to
808655f
Compare
corverroos
approved these changes
Sep 13, 2022
| return core.UnsignedDataSet{}, err | ||
| } | ||
|
|
||
| resp[pubkey] = core.AggregatedAttestation{ |
There was a problem hiding this comment.
Isn't there a core.NewAggregateAttesation(aggAtt) function?
There was a problem hiding this comment.
No. I created a new type for aggregate attestation implementing unsignedData
// AggregatedAttestation wraps Attestation and implements the UnsignedData interface.
type AggregatedAttestation struct {
eth2p0.Attestation
}
xenowits
force-pushed
the
xenowits/fetcher-duty-aggregator
branch
from
808655f
to
22ef729
Compare
xenowits
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for
DutyAggregatortofetcher.category: feature
ticket: #1088