Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/dutydb: add support for DutyPrepareAggregator to DutyDB #1080

Merged
merged 3 commits into from
Sep 6, 2022

Conversation

dB2510
Copy link
Contributor

@dB2510 dB2510 commented Sep 6, 2022

Adds support for DutyPrepareAggregatir to DutyDB.

category: feature
ticket: #1064

@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Merging #1080 (47f780a) into main (4a3fac7) will increase coverage by 0.15%.
The diff coverage is 72.44%.

@@            Coverage Diff             @@
##             main    #1080      +/-   ##
==========================================
+ Coverage   53.47%   53.62%   +0.15%     
==========================================
  Files         126      126              
  Lines       14120    14211      +91     
==========================================
+ Hits         7550     7620      +70     
- Misses       5505     5523      +18     
- Partials     1065     1068       +3     
Impacted Files Coverage Δ
core/interfaces.go 0.00% <ø> (ø)
core/unsigneddata.go 44.05% <64.00%> (+2.81%) ⬆️
core/dutydb/memory.go 71.25% <75.34%> (+1.48%) ⬆️
app/app.go 59.21% <0.00%> (+0.58%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@corverroos corverroos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@dB2510 dB2510 linked an issue Sep 6, 2022 that may be closed by this pull request
@dB2510 dB2510 added the merge when ready Indicates bulldozer bot may merge when all checks pass label Sep 6, 2022
@obol-bulldozer obol-bulldozer bot merged commit 4f23c4d into main Sep 6, 2022
@obol-bulldozer obol-bulldozer bot deleted the dhruv/prepaggdutydb branch September 6, 2022 13:32
dB2510 added a commit that referenced this pull request Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add DutyPrepareAggregator to DutyDB
2 participants