p2p: refactor connectedness logger #1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1001 +/- ##
==========================================
+ Coverage 53.80% 54.16% +0.35%
==========================================
Files 117 118 +1
Lines 13141 13215 +74
==========================================
+ Hits 7071 7158 +87
+ Misses 5044 5030 -14
- Partials 1026 1027 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
corverroos
commented
Aug 19, 2022
| @@ -291,7 +291,7 @@ func NewDiscoveryRouter(tcpNode host.Host, udpNode *MutableUDPNode, peers []Peer | |||
| // it returns false if the peer isn't discovered. | |||
| func getDiscoveredAddress(udpNode *MutableUDPNode, p Peer) (ma.Multiaddr, bool, error) { | |||
| resolved := udpNode.Resolve(&p.Enode) | |||
| if resolved.Seq() == 0 || resolved.TCP() == 0 { | |||
| if resolved.Seq() == p.Enode.Seq() || resolved.TCP() == 0 { | |||
There was a problem hiding this comment.
Do not consider lock file ENRs as "discovered".
| @@ -88,7 +88,11 @@ func (s *Sender) addResult(ctx context.Context, peerID peer.ID, err error) { | |||
| } | |||
| } else if failure && (len(state.buffer) == 1 || !state.failing) { | |||
| // First attempt failed or state changed to failing | |||
| log.Warn(ctx, "P2P sending failing", err, z.Str("peer", PeerName(peerID))) | |||
|
|
|||
| if _, ok := dialErrMsgs(err); !ok { // Only log non-dial errors | |||
There was a problem hiding this comment.
dial errors exclusively logged by ping service
xenowits
reviewed
Aug 20, 2022
p2p/errors.go
Outdated
| "github.com/obolnetwork/charon/app/errors" | ||
| ) | ||
|
|
||
| // hasErrDialBackoff returns true if the error is contains swarm.ErrDialBackoff. |
There was a problem hiding this comment.
Suggested change
| // hasErrDialBackoff returns true if the error is contains swarm.ErrDialBackoff. | |
| // hasErrDialBackoff returns true if the error is or contains swarm.ErrDialBackoff. |
xenowits
approved these changes
Aug 20, 2022
corverroos
added
the
merge when ready
corverroos
force-pushed
the
corver/pinglog
branch
from
9d3f9bc
to
82e2b90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the p2p connectedness logging:
category: refactor
ticket: #986