Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update readyz gauge asynchronously #880

Closed
dB2510 opened this issue Jul 29, 2022 · 0 comments · Fixed by #867
Closed

Update readyz gauge asynchronously #880

dB2510 opened this issue Jul 29, 2022 · 0 comments · Fixed by #867
Assignees
@dB2510
Labels
bug Something isn't working

Comments

@dB2510
Copy link
Contributor

dB2510 commented Jul 29, 2022 •
edited
Loading

Problem to be solved

Currently we expose an endpoint to check charon's health as /readyz on monitoringapi base URL which also updates the readyz gauge. Note that this gauge only updates if the endpoint is called which gives inaccurate results on grafana dashboard.

Proposed solution

Asynchronously update readyz gauge every 10s. Also maintain an internal state which will be read when /readyz endpoint is called.
@dB2510 dB2510 self-assigned this Jul 29, 2022
@dB2510 dB2510 added bug Something isn't working Size: 3 labels Jul 29, 2022
@dB2510 dB2510 mentioned this issue Jul 29, 2022
Merged
@dB2510 dB2510 linked a pull request Jul 29, 2022 that will close this issue
app: push readyz in background #867
Merged
obol-bulldozer bot pushed a commit that referenced this issue Jul 29, 2022
@dB2510
app: push readyz in background (#867)
a17bbb4 
This change pushed readyz metrics every 1 second. Earlier we were pushing this metric only when someone calls readyz endpoint. If no-one calls that endpoint it will show inactive on readyz grafana panel.

category: bug
ticket: #880
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dB2510 dB2510

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

app: push readyz in background ObolNetwork/charon
1 participant
@dB2510