Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: rename ports #732

Closed
xenowits opened this issue Jun 20, 2022 · 2 comments · Fixed by #733
Closed

refactor: rename ports #732

xenowits opened this issue Jun 20, 2022 · 2 comments · Fixed by #733

Comments

@xenowits
Copy link
Contributor

Problem to be solved

Currently, we have the following ports:

  • bootnode: 16005
  • monitoring-address: 16001
  • validator-api-address: 16002
  • charonp2p: 16003
  • discv4: 16004

Proposed solution

Change the ports as follows:

  • p2p-tcp-address: 3600 (TCP+UDP - Needs to be opened)
  • validator-api-address: 3610 (TCP)
  • monitoring: 3620
  • p2p-udp-address: 3630 (until removed). Also, UDP Discv5 port to be removed with libp2p upgrade
  • bootnode-http-address: 3640 (until removed). Also, move ENR server to monitoring server and healthchecks
@xenowits xenowits mentioned this issue Jun 20, 2022
Merged
@dB2510 dB2510 linked a pull request Jun 21, 2022 that will close this issue
refactor: change ports #733
Merged
obol-bulldozer bot pushed a commit that referenced this issue Jun 21, 2022
@xenowits
refactor: change ports (#733)
5e67194 
Change ports from `16000`s to `3600`s.

category: refactor
ticket: #732
@OisinKyne OisinKyne reopened this Jun 21, 2022
@OisinKyne
Copy link
Contributor

Super nit-picky change sorry 😭

Lets make charon-p2p 3610, and validatorapi 3600, because the validatorapi is the piece every dev will have to touch but charonp2p can stay default almost always.

@xenowits xenowits mentioned this issue Jun 22, 2022
Merged
@xenowits
Copy link
Contributor Author

xenowits commented Jun 22, 2022 •
edited
Loading

Super nit-picky change sorry 😭

Lets make charon-p2p 3610, and validatorapi 3600, because the validatorapi is the piece every dev will have to touch but charonp2p can stay default almost always.

@OisinKyne raised a PR

obol-bulldozer bot pushed a commit that referenced this issue Jun 22, 2022
@xenowits
refactor: reassign ports 3600 and 3610 (#740)
24ab3dd 
Change `p2p-tcp-address` to 3610 and `validator-api-address` to 3600.

category: refactor
ticket: #732
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: change ports ObolNetwork/charon
2 participants
@OisinKyne @xenowits