Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dkg: improve logging #587

Closed
corverroos opened this issue May 23, 2022 · 0 comments · Fixed by #633
Closed

dkg: improve logging #587

corverroos opened this issue May 23, 2022 · 0 comments · Fixed by #633
Assignees
@xenowits

Comments

@corverroos
Copy link
Contributor

Problem to be solved

During DKG the following line is logged right after the keys are generated.

"Successfully completed DKG ceremony, writing output"

There are however multiple steps after this that can also fail, so logging Successfully completed DKG ceremony isn't accurate.

Proposed solution

Change that logging and also add more logging to improve UX of the DKG.
@xenowits xenowits self-assigned this May 26, 2022
@xenowits xenowits mentioned this issue May 31, 2022
Merged
@xenowits xenowits linked a pull request May 31, 2022 that will close this issue
log: add logs to dkg #633
Merged
obol-bulldozer bot pushed a commit that referenced this issue May 31, 2022
@xenowits
log: add logs to dkg (#633)
9a83f81 
Add more debug/info logs to dkg ceremony

category: refactor
ticket: #587
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xenowits xenowits

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

log: add logs to dkg ObolNetwork/charon
3 participants
@Battenfield @corverroos @xenowits