Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dkg: command hangs if one peer drops out #586

Closed
corverroos opened this issue May 23, 2022 · 1 comment
Closed

dkg: command hangs if one peer drops out #586

corverroos opened this issue May 23, 2022 · 1 comment
Assignees
@dB2510

Comments

@corverroos
Copy link
Contributor

corverroos commented May 23, 2022 •
edited by dB2510
Loading

Problem to be solved

The charon dkg command hangs if one peer drops out/errors after the waitForPeers step. This is because there are multiple steps where code waits for all peers to broadcast messages. If one peer doesn't, it just blocks and waits forever.

Proposed solution

Implement this TODO in charon/dkg/dkg.go:511:

	// TODO(corver): This can be improved by returning a context that is
	//  cancelled as soon as the connection to a single peer is lost.
@corverroos corverroos changed the title DKG hangs if one peer drops out dkg: command hangs if one peer drops out May 23, 2022
@dB2510 dB2510 self-assigned this May 26, 2022
@dB2510 dB2510 mentioned this issue Jun 3, 2022
Merged
obol-bulldozer bot pushed a commit that referenced this issue Jun 6, 2022
@dB2510
dkg: cancel context to wait peers (#662)
e05f7dd 
Cancels context if unable to connect to any peer.

category: bug
ticket: #586
@corverroos corverroos mentioned this issue Jun 6, 2022
Merged
obol-bulldozer bot pushed a commit that referenced this issue Jun 7, 2022
@corverroos
dkg: fix wait peer issue (#671)
6f1238e 
Fixes `waitPeer` issue where ping is closed as soon as connected.

category: bug 
ticket: #586
@dB2510
Copy link
Contributor

dB2510 commented Jun 7, 2022

Closed by #662 and #671

@dB2510 dB2510 closed this as completed Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dB2510 dB2510

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Battenfield @corverroos @dB2510