Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd: ensure valid network during create dkg #583

Closed
corverroos opened this issue May 23, 2022 · 0 comments · Fixed by #598
Closed

cmd: ensure valid network during create dkg #583

corverroos opened this issue May 23, 2022 · 0 comments · Fixed by #598
Assignees
@dB2510
Labels
bug Something isn't working

Comments

@corverroos
Copy link
Contributor

Problem to be solved

The charon create dkg command doesn't validate network/forkversion, not does it have a default. This results in empty values by default.

Proposed solution

  • Add a flag to define the network in the charon create dkg command.
  • Add a default value (mainnet?)
  • Verify the network when provided.
@corverroos corverroos added the bug Something isn't working label May 23, 2022
@dB2510 dB2510 self-assigned this May 23, 2022
@dB2510 dB2510 mentioned this issue May 23, 2022
Merged
@dB2510 dB2510 linked a pull request May 23, 2022 that will close this issue
cmd: ensures valid network during create dkg #598
Merged
obol-bulldozer bot pushed a commit that referenced this issue May 24, 2022
@dB2510
cmd: ensures valid network during create dkg (#598)
f56ceb3 
Ensures valid network during create dkg using network flag which is then used to get fork version to create cluster definition.

category: bug
ticket: #583
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dB2510 dB2510

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cmd: ensures valid network during create dkg ObolNetwork/charon
2 participants
@corverroos @dB2510