Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QBFT: Only trigger each upon rule once per round #523

Closed
corverroos opened this issue May 13, 2022 · 0 comments
Closed

QBFT: Only trigger each upon rule once per round #523

corverroos opened this issue May 13, 2022 · 0 comments
Assignees
@leolara
Labels
enhancement New feature or request

Comments

@corverroos
Copy link
Contributor

Problem to be solved

The QBFT paper states that each upon rules should only be triggered once per round (with the exception of uponJustifiedDecided.

The current implementation allows for rules to be triggered multiple times.

Note this isn't such a big problem, since the algorithm is idempotent, the only affect is that more messages are sent over the wire then necessary.

Proposed solution

  • Similar to dedupIn, implement a dedupRule map to deduplicate upon rules per round.
  • Remember to trim that map in trimBuffer
@corverroos corverroos added the enhancement New feature or request label May 13, 2022
@leolara leolara mentioned this issue May 14, 2022
Merged
@leolara leolara self-assigned this May 14, 2022
obol-bulldozer bot pushed a commit that referenced this issue May 15, 2022
@leolara
core/qbft: only trigger each upon rule once per round (#536)
4b27eb2 
The QBFT paper states that each upon rules should only be triggered once per round (with the exception of uponJustifiedDecided.

The current implementation allows for rules to be triggered multiple times.

Note this isn't such a big problem, since the algorithm is idempotent, the only affect is that more messages are sent over the wire then necessary.

category: refactor
ticket: #523
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leolara leolara

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@leolara @corverroos