Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature flag to enable JSON-encoded block submission #3108

Closed
3 tasks
boulder225 opened this issue May 29, 2024 · 1 comment
Closed
3 tasks

Feature flag to enable JSON-encoded block submission #3108

boulder225 opened this issue May 29, 2024 · 1 comment
Assignees
@pinebit
Labels
protocol Protocol Team tickets

Comments

@boulder225
Copy link

boulder225 commented May 29, 2024 •
edited by gsora
Loading

🎯 Problem to be solved

The Nimbus beacon node requires JSON-encoded blocks to be submitted via the /eth/v2/beacon/blocks endpoint. However, the current implementation of the go-eth2-client library does not support this format for Nimbus, leading to issues when using Nimbus as a beacon node in Kurtosis.

🛠️ Proposed solution

  • Introduce a feature flag (e.g., --feature-set-enable=json_requests) in Charon to enable JSON-encoded block submission for Nimbus.
  • Document the requirement for enabling the JSON-encoded block submission feature when using Nimbus as a beacon node in the release notes.
  • Plan for eventual removal of the feature flag once Nimbus and other beacon nodes support the SSZ-encoded block format natively.
@github-actions github-actions bot added the protocol Protocol Team tickets label May 29, 2024
@boulder225
Copy link
Author

Hey team! Please add your planning poker estimate with Zenhub @gsora @KaloyanTanev @pinebit

@pinebit pinebit mentioned this issue May 29, 2024
Merged
obol-bulldozer bot pushed a commit that referenced this issue May 30, 2024
@pinebit
app: json_requests feature (#3110)
278bcf7 
Add `WithEnforceJSON(true)` parameter when `json_requests` feature is enabled in `featureset`.
This is needed for Nimbus BN to properly handle SubmitProposal requests.

category: feature
ticket: #3108
feature_flag: json_requests
@pinebit pinebit closed this as completed May 30, 2024
KaloyanTanev pushed a commit that referenced this issue Jun 5, 2024
@pinebit @KaloyanTanev
app: json_requests feature (#3110)
651187b 
Add `WithEnforceJSON(true)` parameter when `json_requests` feature is enabled in `featureset`.
This is needed for Nimbus BN to properly handle SubmitProposal requests.

category: feature
ticket: #3108
feature_flag: json_requests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pinebit pinebit

Labels
protocol Protocol Team tickets
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pinebit @boulder225