p2p: fix test-related data race #2763
Labels
protocol
Protocol Team tickets
Comments
This was referenced Feb 8, 2024
Merged
obol-bulldozer bot
pushed a commit
that referenced
this issue
Feb 8, 2024
This PR: - fixes a data race in p2p.Sender which was flapping in integration and compose tests - makes "prepare round 2, decide round 3" QBFT internal test more reliable; tested empirically by running the test 100.000 times, usually the flapping issue manifested itself after a couple runs category: bug ticket: #2763 Closes #2763.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
🐞 Bug Report
Description
There is a low-consequences data race happening in the
p2ppackage: https://github.com/ObolNetwork/charon/actions/runs/7289045255/job/19862855243?pr=2762#step:5:2191.This issue can be fixed by synchronizing access to
peerState.buffer.🔬 Minimal Reproduction
Run integration tests with a high
-countvalue.🔥 Error
https://github.com/ObolNetwork/charon/actions/runs/7289045255/job/19862855243?pr=2762#step:5:2191
The text was updated successfully, but these errors were encountered: