Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect delay duration in submitted validator registrations logs #2681

Closed
dB2510 opened this issue Nov 7, 2023 · 0 comments · Fixed by #2675
Closed

Incorrect delay duration in submitted validator registrations logs #2681

dB2510 opened this issue Nov 7, 2023 · 0 comments · Fixed by #2675
Assignees
Labels
protocol Protocol Team tickets

Comments

@dB2510
Copy link
Contributor

dB2510 commented Nov 7, 2023

🐞 Bug Report

Description

When charon's broadcaster component broadcasts any duty it logs the Submitted successfully log for all the duties which includes delay duration. Here's the log when validator registrations are broadcasted:

12:32:23.134 INFO bcast      Successfully submitted validator registration to beacon node {"delay": "25416h32m0.13494757s", "pubkey": "858_9bf", "duty": "0/builder_registration"}

As we can see in the above log the delay time is incorrect as it takes slot number into account and calculates delay from the genesis time. This should take the delay from the start of current epoch as validator registrations are broadcasted at the start of each epoch.

Has this worked before in a previous version?

No

🔬 Minimal Reproduction

Run v0.17.0 with v1.7.0 cluster-lock with --builder-api-enabled=true.

🔥 Error


12:32:23.134 INFO bcast      Successfully submitted validator registration to beacon node {"delay": "25416h32m0.13494757s", "pubkey": "858_9bf", "duty": "0/builder_registration"}

🌍 Your Environment

What version of Charon are you running? (Which release)

  
v0.17.0
  
@dB2510 dB2510 self-assigned this Nov 7, 2023
@github-actions github-actions bot added the protocol Protocol Team tickets label Nov 7, 2023
@dB2510 dB2510 linked a pull request Nov 7, 2023 that will close this issue
obol-bulldozer bot pushed a commit that referenced this issue Nov 7, 2023
This PR fixes delay reports by bcast for builder registration duty. As reported multiple times:

```
12:32:23.134 INFO bcast      Successfully submitted validator registration to beacon node {"delay": "25416h32m0.13494757s", "pubkey": "858_9bf", "duty": "0/builder_registration"}
```

category: bug
ticket: #2681
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protocol Protocol Team tickets
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant