Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chain inclusion for builder_proposer is not working as expected #2661

Closed
dB2510 opened this issue Oct 26, 2023 · 1 comment
Closed

Chain inclusion for builder_proposer is not working as expected #2661

dB2510 opened this issue Oct 26, 2023 · 1 comment
Assignees
Labels
bug Something isn't working protocol Protocol Team tickets v0.18.0

Comments

@dB2510
Copy link
Contributor

dB2510 commented Oct 26, 2023

🐞 Bug Report

Description

Recently as part of tracking successes of blinded blocks using tracker we found out that some peers in the cluster were reporting failures due to chain inclusion error but the block was proposed successfully.

Has this worked before in a previous version?

No.

🔬 Minimal Reproduction

Check the logs of the cluster: DSRV-3cluster

🔥 Error


WARN tracker    Broadcasted blinded block never included on-chain {"pubkey": "a09_ed6", "block_slot": 6817827, "broadcast_delay": "58.441230209s"}

But this block was actually proposed successfully: https://goerli.beaconcha.in/slot/6817827

🌍 Your Environment

What version of Charon are you running? (Which release)

  
This cluster is running v0.17.0
  

Anything else relevant (validator index / public key)?
Public key: 0xa09953ebb5f425910fed77ef08fbe091a816cb3756f1a4423e58fa1a8d0e9a7730ebbb98a64804b6354a221e3813ed62

Validator Index: 586718

@github-actions github-actions bot added the protocol Protocol Team tickets label Oct 26, 2023
@dB2510 dB2510 self-assigned this Oct 26, 2023
@dB2510 dB2510 added v0.18.0 bug Something isn't working labels Oct 31, 2023
obol-bulldozer bot pushed a commit that referenced this issue Nov 1, 2023
Fixes inclusion checker bug which was reporting false negatives about the inclusion blinded blocks. This happened because of misconfiguration between deadline of a duty and inclusion checker lag. Duty deadline of `builder_proposer` is 5 slots while inclusion lag is 4 slots. Inclusion checker should start checking after duty deadline is hit to avoid getting any submissions after that.
Which is why even the blinded block was _actually_ proposed successfully, inclusion checker marked it failed as duty was still active and retryer was busy retrying `blinded_block` submission request.

category: bug
ticket: #2661
@dB2510
Copy link
Contributor Author

dB2510 commented Nov 3, 2023

Closed by #2670

@dB2510 dB2510 closed this as completed Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working protocol Protocol Team tickets v0.18.0
Projects
None yet
Development

No branches or pull requests

1 participant