Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cluster failing attestations with mixed node versions #2386

Closed
dB2510 opened this issue Jul 3, 2023 · 1 comment · Fixed by #2387
Closed

Cluster failing attestations with mixed node versions #2386

dB2510 opened this issue Jul 3, 2023 · 1 comment · Fixed by #2387
Assignees
@dB2510
Labels
protocol Protocol Team tickets

Comments

@dB2510
Copy link
Contributor

dB2510 commented Jul 3, 2023

🐞 Bug Report

Description

It has been found that canary clusters running mixed versions are throwing the following errors:
image

The above logs are from a node running with v0.16.0 and trying to communicate to nodes running v0.17-dev version.

Has this worked before in a previous version?

Yes, the previous version in which this bug was not present was: 3435f00

🔬 Minimal Reproduction

Run a mixed versions cluster with half of nodes running on v0.16.0 and other half on 7374a44.

🔥 Error


protocols not supported

What version of Charon are you running? (Which release)

  
Half on v0.16.0 AND half on 7374a44
@dB2510 dB2510 self-assigned this Jul 3, 2023
@dB2510
Copy link
Contributor Author

dB2510 commented Jul 3, 2023

This bug is caused because p2p.Send(...) in v0.16.0 does not support multiple protocols. We can fix this by:

@github-actions github-actions bot added the protocol Protocol Team tickets label Jul 3, 2023
@dB2510 dB2510 mentioned this issue Jul 3, 2023
Merged
@dB2510 dB2510 linked a pull request Jul 3, 2023 that will close this issue
p2p: add support for multi protocols to Send #2387
Merged
obol-bulldozer bot pushed a commit that referenced this issue Jul 3, 2023
@dB2510
p2p: add support for multi protocols to Send (#2387)
aba2bb5 
Add support for multi protocols to `p2p.Send(...)`.

category: bug
ticket: #2386
@dB2510 dB2510 mentioned this issue Jul 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dB2510 dB2510

Labels
protocol Protocol Team tickets
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

p2p: add support for multi protocols to Send ObolNetwork/charon
1 participant
@dB2510