Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify commitments lengths in DKG #1999

Closed
gsora opened this issue Apr 3, 2023 · 0 comments · Fixed by #2007
Closed

Verify commitments lengths in DKG #1999

gsora opened this issue Apr 3, 2023 · 0 comments · Fixed by #2007
Assignees
@gsora
Labels
bug Something isn't working protocol Protocol Team tickets sigp audit Issues identified by sigma prime audit

Comments

@gsora
Copy link
Collaborator

gsora commented Apr 3, 2023

🐞 Bug Report

Description

Frost DKG still uses Kryptology as its cryptography library due to strict dependencies on it.

Kryptology's FeldmanVerifier.Verify() doesn't check that polynomial commitments are of length t+1, where t is the threshold of malicious nodes.
@gsora gsora added the bug Something isn't working label Apr 3, 2023
@gsora gsora self-assigned this Apr 3, 2023
@github-actions github-actions bot added the protocol Protocol Team tickets label Apr 3, 2023
@dB2510 dB2510 added the sigp audit Issues identified by sigma prime audit label Apr 3, 2023
gsora added a commit that referenced this issue Apr 4, 2023
@gsora
dkg: ensure that during round 1, the received commitments match the a…
c625c7b 
…mount of peers

Addresses OBOL-01, closes #1999.
@gsora gsora mentioned this issue Apr 4, 2023
Merged
obol-bulldozer bot pushed a commit that referenced this issue Apr 4, 2023
@gsora
dkg: ensure number of commitments (#2007)
910ea1b 
Addresses OBOL-01, closes #1999.

category: bug
ticket: #1999
LukeHackett12 pushed a commit that referenced this issue Apr 11, 2023
@gsora @LukeHackett12
dkg: ensure number of commitments (#2007)
b40a61f 
Addresses OBOL-01, closes #1999.

category: bug
ticket: #1999
@gsora gsora mentioned this issue Apr 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gsora gsora

Labels
bug Something isn't working protocol Protocol Team tickets sigp audit Issues identified by sigma prime audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dkg: ensure number of commitments ObolNetwork/charon
2 participants
@gsora @dB2510