Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues found by beacon mock fuzz #1962

Closed
2 of 4 tasks
dB2510 opened this issue Mar 29, 2023 · 0 comments
Closed
2 of 4 tasks

Fix issues found by beacon mock fuzz #1962

dB2510 opened this issue Mar 29, 2023 · 0 comments
Assignees
@dB2510
Labels
protocol Protocol Team tickets

Comments

@dB2510
Copy link
Contributor

dB2510 commented Mar 29, 2023 •
edited
Loading

🎯 Problem to be solved

We recently added a flag to compose CLI which runs beacon mock fuzz as part of #1848 . It reports panic caused by random beaconmock responses.

🛠️ Proposed solution

  • Approved design doc: link

  • Core team consensus on the proposed solution

  • Fix all panic errors reported by beacon mock fuzz. Run the following command repeatedly and for long time to check panic:
    compose new --build-local --validator-types=mock --fuzz && compose auto

  • Add a fuzz test similar to smoke tests (testutil/compose/smoke/smoke_test.go) in compose which runs beacon mock fuzz on CI.

🧪 Tests

  • Tested by new automated fuzz tests on CI.
  • Manually tested on local compose simnet
@github-actions github-actions bot added the protocol Protocol Team tickets label Mar 29, 2023
@dB2510 dB2510 self-assigned this Apr 5, 2023
@dB2510 dB2510 mentioned this issue Apr 14, 2023
Merged
obol-bulldozer bot pushed a commit that referenced this issue Apr 19, 2023
@dB2510
testutil/beaconmock: fix fuzz issues (#2105)
b4f7a06 
Fixes panics found by initial beacon fuzz tests. Also improve efficiency of beacon fuzzer to trigger more panics in charon workflow.

category: test
ticket: #1962
@dB2510 dB2510 mentioned this issue Apr 26, 2023
Merged
obol-bulldozer bot pushed a commit that referenced this issue Apr 27, 2023
@dB2510
core: fixes some more panics (#2137)
9fb17a6 
Fixes some more panics found by beacon fuzz.

category: misc
ticket: #1962
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dB2510 dB2510

Labels
protocol Protocol Team tickets
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dB2510 @thomasheremans