Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clock diff still includes connection opening delay #1494

Closed
corverroos opened this issue Nov 29, 2022 · 1 comment
Closed

Clock diff still includes connection opening delay #1494

corverroos opened this issue Nov 29, 2022 · 1 comment
Assignees
@xenowits

Comments

@corverroos
Copy link
Contributor

corverroos commented Nov 29, 2022 •
edited
Loading

Problem to be solved

We tried to fix clock diff spikes in #1474 but it didn't work since it only fixes the RTT calculation. It doesn't fix the "sentAt" part of the calculation which still include connection opening delay.

Proposed solution

Instead of using sentAt+rtt/2 to calculate expectedSentAt, use now()-rtt/2.
@corverroos corverroos mentioned this issue Dec 7, 2022
Closed
@xenowits xenowits mentioned this issue Jan 5, 2023
Merged
obol-bulldozer bot pushed a commit that referenced this issue Jan 5, 2023
@xenowits
peerinfo: fix clock diff calculation (#1592)
3ad9b9d 
Fixes clock diff calculation to exclude connection opening.

category: refactor
ticket: #1494
@xenowits
Copy link
Contributor

xenowits commented Jan 6, 2023 •
edited
Loading

Clock offset graph with the included changes:
24 hrs
Screenshot 2023-01-06 at 20 20 53
1 hr
Screenshot 2023-01-06 at 20 24 24

Observation: The spikes seems to be gone and the graph looks much better than noted previously.

@xenowits xenowits closed this as completed Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xenowits xenowits

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@corverroos @xenowits