Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current connections is not a valid proxy for peer connectedness #1426

Closed
corverroos opened this issue Nov 10, 2022 · 0 comments
Closed

Current connections is not a valid proxy for peer connectedness #1426

corverroos opened this issue Nov 10, 2022 · 0 comments

Comments

@corverroos
Copy link
Contributor

🐞 Bug Report

Description

We use current connections to check if we are connected to sufficient peers. This is however incorrect since connections break (especially relay connections) and are only re-established when the next message is sent. In most cases, the connection will be re-established and everything will be fine.

Proposed solution

Instead of "current connections", use "recent connections" (1 min should be fine). So keep a timestamp of last seen connection and if that is more than 1min, then count the peer as "not connected".

obol-bulldozer bot pushed a commit that referenced this issue Nov 14, 2022
Increase readyz insufficient peers hysteresis from 30s to 1min.

category: bug
ticket: #1426
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants