Skip to content
This repository has been archived by the owner on Dec 27, 2021. It is now read-only.

Externalize chains #9

Open
wpiers opened this issue Jun 24, 2021 · 3 comments
Open

Externalize chains #9

wpiers opened this issue Jun 24, 2021 · 3 comments
Assignees
@mypsycho
Labels
P2 refactoring
Milestone
M3

Comments

@wpiers
Copy link
Collaborator

wpiers commented Jun 24, 2021

/!\ about 15k
@wpiers wpiers added this to the M1 milestone Jun 24, 2021
@wpiers wpiers changed the title Internationalize chains Externalize chains Jul 12, 2021
wpiers added a commit that referenced this issue Jul 12, 2021
@wpiers
[#9] Generated missing NLS tags
7543836 
Change-Id: Id42c206cd3a895b50d695e286f97101dee50bea2
wpiers added a commit that referenced this issue Jul 13, 2021
@wpiers
[#9] Added missing NLS tags
2f37831 
Change-Id: I3538e5f8def5f710dfcb8832feea135b60709d72
@wpiers
Copy link
Collaborator Author

wpiers commented Jul 13, 2021

After a first pass to separate externalizable chains from the others by adding NON-NLS tags, about 1000 chains needs externalization.

@wpiers wpiers modified the milestones: M1, M2 Jul 27, 2021
@wpiers wpiers added the P2 label Sep 6, 2021
@wpiers wpiers added P3 and removed P2 labels Sep 27, 2021
@wpiers wpiers removed the P3 label Oct 11, 2021
@wpiers wpiers modified the milestones: M2, M3 Oct 11, 2021
@wpiers wpiers added the P2 label Oct 13, 2021
@mypsycho
Copy link
Collaborator

mypsycho commented Oct 25, 2021 •
edited
Loading

Analysis

  • org.eclipse.poosl.model.edit: 8 items
  • org.eclipse.poosl.pooslproject: 20 items
  • org.eclipse.poosl.rotalumisclient: 337 items
  • org.eclipse.poosl.sirius: 205 items
  • org.eclipse.poosl.transformations: 18 items
  • org.eclipse.poosl.xtext: 161 items (excluding src-gen)
  • org.eclipse.poosl.xtext.ide: 0 items (excluding src-gen)
  • org.eclipse.poosl.xtext.ui: 271 items (excluding src-gen)

How to
To ensure no local String is used 2 tools are needed:

  • Detection with Properties:java / compiler / errors/Warnings : non-externalized strings = error
  • <ctxt>/source/Externalized String to create properties files once all technical string are escaped.

Detail

  • xtext plugins contain items in generated files. Escaping such files is made through
    /org.eclipse.poosl.xtext.tooling/workflow/GeneratePoosl.mwe2
  • Odesign contains String that are not detected by i18n tool

@mypsycho mypsycho self-assigned this Nov 2, 2021
mypsycho pushed a commit that referenced this issue Nov 3, 2021
@peransin-obeo
[#9] Set i18n in ODesign labels.
750fd01
@mypsycho
Copy link
Collaborator

mypsycho commented Nov 3, 2021 •
edited
Loading

org.eclipse.poosl.xtext.custom.FormattingHelper is a major problem for i18n.

It mixes technical StringBuilding (method signature) and user messages.

Complete reengineering is required:

  • detecte use-case.
  • sort technical usage from display usage.
  • refactor each string build.

Direct usage :

  • org.eclipse.poosl.sirius.services.ClassDiagramServices
  • org.eclipse.poosl.transformations.poosl2html.Poosl2Html
  • org.eclipse.poosl.xtext.descriptions.PooslDataMethodDescription
  • org.eclipse.poosl.xtext.descriptions.PooslProcessMethodDescription
  • org.eclipse.poosl.xtext.validation.PooslJavaValidatorAcyclicRelations
  • org.eclipse.poosl.xtext.validation.PooslJavaValidatorMisc
  • org.eclipse.poosl.xtext.validation.PooslJavaValidatorMisc
  • org.eclipse.poosl.xtext.ui.contentassist.PooslProposalProviderLabel
  • org.eclipse.poosl.xtext.ui.labeling.PooslLabelProvider
  • org.eclipse.poosl.xtext.ui.outline.PooslOutlineTreeProvider
  • org.eclipse.poosl.xtext.ui.quickfix.PooslQuickfixProviderTypes

mypsycho pushed a commit that referenced this issue Nov 5, 2021
@peransin-obeo
[#9] Improve String seperation for i18n.
b6fb20e
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mypsycho mypsycho

Labels
P2 refactoring
Projects
None yet
Milestone
M3
Development

No branches or pull requests
2 participants
@mypsycho @wpiers