Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fx for challenge29 #949

Merged
merged 8 commits into from
Aug 29, 2023
Merged

Fx for challenge29 #949

merged 8 commits into from
Aug 29, 2023
+39 −17

Conversation

commjoen
Copy link
Collaborator

@commjoen commjoen commented Aug 28, 2023 •
edited
Loading

What kind of changes does this PR include?

  • Fixes or refactors
  • A new challenge
  • Additional documentation
  • Something else

Description

Relations

Fixes #946

References

Checklist:

  • All the contributions made are solely the work of me and my co-authors
  • I tested the changes in this PR (if applicable)
  • I added unit tests to ensure my change works (when change in Java or on front-end code)
  • I added UI tests to ensure my UI changes work (when change in the overall UI, not needed if just adding a challenge)
  • The PR passes pre-commit hooks and automated tests

@commjoen commjoen changed the title possible fix for challenge29 Fx for challenge29 Aug 29, 2023
@commjoen commjoen merged commit 0d4e17b into master Aug 29, 2023
14 of 15 checks passed
@commjoen commjoen deleted the bugfix-challenge28 branch August 29, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bendehaan bendehaan bendehaan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@commjoen @bendehaan