Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#630 Docker image jeroenwillemsen/wrongsecrets:1.5.14-no-vault hangs … #631

Merged

Conversation

drnow4u
Copy link
Collaborator

@drnow4u drnow4u commented Feb 22, 2023

…on Colima container runtimes on macOS with M1

Thank you for submitting a pull request to the WrongSecrets app!

What kind of changes does this PR include?

Checklist:

  • All the contributions made are solely the work of me and my co-authors
  • I tested the changes in this PR (if applicable)
  • I added unit tests to ensure my change works (when change in Java or on front-end code)
  • The PR passes pre-commit hooks and automated tests

…angs on Colima container runtimes on macOS with M1
README.md Outdated Show resolved Hide resolved
commjoen added a commit that referenced this pull request Feb 28, 2023
commjoen added a commit that referenced this pull request Feb 28, 2023
commjoen added a commit that referenced this pull request Feb 28, 2023
commjoen added a commit that referenced this pull request Feb 28, 2023
commjoen added a commit that referenced this pull request Feb 28, 2023
commjoen added a commit that referenced this pull request Feb 28, 2023
feat(#631): fix podman - move to ubuntu

Update podman-test.yml

Update podman-test.yml

Update podman-test.yml

Update podman-test.yml
commjoen added a commit that referenced this pull request Feb 28, 2023
commjoen added a commit that referenced this pull request Feb 28, 2023
@commjoen
Copy link
Collaborator

When you have approved #651 , then you can refer to the actions for alternative docker runtimes like colima and podman :).

puneeth072003 added a commit to puneeth072003/wrongsecrets that referenced this pull request Mar 2, 2023
* feat(OWASP#631):first podman test

* Create SECURITY.md

* feat(OWASP#631): Added forgotten podman steps

feat(OWASP#631): fix podman - move to ubuntu

Update podman-test.yml

Update podman-test.yml

Update podman-test.yml

Update podman-test.yml

* feat(OWASP#631): adding colima and podman

* feat(OWASP#630): fix podman to search at docker.io

* feat(OWASP#630/OWASP#631): colima and podman tests

* feat(OWASP#630/OWASP#631): colima and podman tests (now with sleep)

* build(deps): bump checkstyle from 10.7.0 to 10.8.0

Bumps [checkstyle](https://github.com/checkstyle/checkstyle) from 10.7.0 to 10.8.0.
- [Release notes](https://github.com/checkstyle/checkstyle/releases)
- [Commits](checkstyle/checkstyle@checkstyle-10.7.0...checkstyle-10.8.0)

---
updated-dependencies:
- dependency-name: com.puppycrawl.tools:checkstyle
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* build(deps): bump cyclonedx-core-java from 7.3.1 to 7.3.2

Bumps [cyclonedx-core-java](https://github.com/CycloneDX/cyclonedx-core-java) from 7.3.1 to 7.3.2.
- [Release notes](https://github.com/CycloneDX/cyclonedx-core-java/releases)
- [Changelog](https://github.com/CycloneDX/cyclonedx-core-java/blob/master/CHANGELOG.md)
- [Commits](CycloneDX/cyclonedx-core-java@cyclonedx-core-java-7.3.1...cyclonedx-core-java-7.3.2)

---
updated-dependencies:
- dependency-name: org.cyclonedx:cyclonedx-core-java
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Update .github/workflows/container-alts-test.yml

Co-authored-by: Ben de Haan <[email protected]>

* Update .github/workflows/container-alts-test.yml

Co-authored-by: Ben de Haan <[email protected]>

* build(deps): bump aws.sdk.version from 2.20.12 to 2.20.14

Bumps `aws.sdk.version` from 2.20.12 to 2.20.14.

Updates `sts` from 2.20.12 to 2.20.14

Updates `ssm` from 2.20.12 to 2.20.14

---
updated-dependencies:
- dependency-name: software.amazon.awssdk:sts
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: software.amazon.awssdk:ssm
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* feat: add issue templates for three categories

fix: add to PR template

fix: rephrase to challenge idea

fix: consistenly use h3

fix: refactor PR template

* feat(security-reporting): Added channel, and less version dependen text

* fix for colima failing with 30 seconds

* Adding Requested changes

all the requested changes are incorporated in this commit.

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Jeroen Willemsen <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ben de Haan <[email protected]>
Nowak M. (Marcin) and others added 4 commits March 17, 2023 14:41
…angs on Colima container runtimes on macOS with M1
…angs on Colima container runtimes on macOS with M1
…nd_Colima' into OWASP#630-Docker_on_macOS_with_M1_and_Colima

# Conflicts:
#	README.md
@commjoen
Copy link
Collaborator

commjoen commented May 4, 2023

@MarcinNowak-codes do you have any update on this :-)?

@commjoen
Copy link
Collaborator

Hi @MarcinNowak-codes , do you have any update on this? Will have to close the pr this week due to inactivity.

@drnow4u
Copy link
Collaborator Author

drnow4u commented May 15, 2023

Hi @commjoen , I’m sorry for late response. Let me check status and your work in #651

@commjoen
Copy link
Collaborator

Welcome back sir!

@drnow4u drnow4u force-pushed the #630-Docker_on_macOS_with_M1_and_Colima branch from a20a04c to 2ab4f10 Compare May 17, 2023 18:55
@drnow4u drnow4u force-pushed the #630-Docker_on_macOS_with_M1_and_Colima branch from 2ab4f10 to 8ff01a4 Compare May 17, 2023 19:01
@drnow4u drnow4u marked this pull request as ready for review May 17, 2023 19:44
@drnow4u drnow4u requested a review from bendehaan as a code owner May 17, 2023 19:44
@drnow4u
Copy link
Collaborator Author

drnow4u commented May 17, 2023

I've just checked again and simplify how to run with different Docker context.

Copy link
Collaborator

@commjoen commjoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@commjoen commjoen merged commit dd9d383 into OWASP:master May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants