Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Challenge51: Misconfiguration of docker secret in code. #1611

Closed
wants to merge 10 commits into from
Closed

Challenge51: Misconfiguration of docker secret in code. #1611

wants to merge 10 commits into from

Conversation

Shubham-Patel07
Copy link
Contributor

What kind of changes does this PR include?

  • Fixes or refactors
  • A new challenge
  • Additional documentation
  • Something else

Description

New challenge created for misconfiguration of docker secret in code.

Relations

Relates #811

Checklist:

  • All the contributions made are solely the work of me and my co-authors
  • I tested the changes in this PR (if applicable)
  • I added unit tests to ensure my change works (when change in Java or on front-end code)
  • I added UI tests to ensure my UI changes work (when change in the overall UI, not needed if just adding a challenge)
  • The PR passes pre-commit hooks and automated tests

bendehaan
bendehaan requested changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@bendehaan bendehaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate the effort!

My two cents: don't really see the challenge using a docker secret as in the explanation. Instead, it's another "hardcoded" secret - could you maybe rebuild it to use a secret like this? And/or a different take on build secrets like this?

@commjoen commjoen changed the title Challenge49: Misconfiguration of docker secret in code. A new Challenge49: Misconfiguration of docker secret in code. Oct 2, 2024
@commjoen commjoen changed the title A new Challenge49: Misconfiguration of docker secret in code. A new Challenge51: Misconfiguration of docker secret in code. Oct 3, 2024
@commjoen commjoen changed the title A new Challenge51: Misconfiguration of docker secret in code. Challenge51: Misconfiguration of docker secret in code. Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@commjoen commjoen commjoen left review comments

@bendehaan bendehaan bendehaan requested changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Shubham-Patel07 @commjoen @bendehaan