Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move gcp ingress to consul/vault script #1140

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Conversation

bendehaan
Copy link
Collaborator

@bendehaan bendehaan commented Dec 13, 2023

What kind of changes does this PR include?

  • Fixes or refactors
  • A new challenge
  • Additional documentation
  • Something else

Description

Harmonise GCP ingress script - fixes resources not ending up in vault namespace and pod not able to resolve vault.

Relations

References

Checklist:

  • All the contributions made are solely the work of me and my co-authors
  • I tested the changes in this PR (if applicable)
  • I added unit tests to ensure my change works (when change in Java or on front-end code)
  • I added UI tests to ensure my UI changes work (when change in the overall UI, not needed if just adding a challenge)
  • The PR passes pre-commit hooks and automated tests

Copy link
Collaborator

@commjoen commjoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLEANUP TIME! JIIHAW! thanks ben!

@commjoen commjoen merged commit 3af6f8f into master Dec 13, 2023
16 checks passed
@commjoen commjoen deleted the fix/gcp-ingress-vault branch December 13, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants