Fix typos in demo threat descriptions #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgadsden
approved these changes
Apr 18, 2024
There was a problem hiding this comment.
Thanks for this @alexvorndran , good to fix typos and going ahead with the merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This pull request fixes some minor typos in the threat descriptions of the demo models (and a test fixture). These aren't critical in the sense that they'd distort the meaning, but the fix may help to improve the first impression of Threat Dragon.
Description for the changelog:
Fix typos in demo threat descriptions
Other info:
Based on my understanding of the end-to-end test that uses the fixture in question (
td.vue/tests/e2e/specs/threatmodel/import.cy.js), the change shouldn't have any effect on the test because the changed description isn't checked. The test is also skipped at the moment.