Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop report options moving and obscuring language drop-down #942

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

michaelgrahamevans
Copy link
Contributor

Summary:

When on the report page, scrolling down the content causes the report options bar to move upwards slightly. Additionally, the report options bar appears above the language selection drop-down menu in the nav bar.

Description for the changelog:

This change tweaks the CSS to correct the heights and margins of the report options bar so that it does not move and it changes the z-index of the report options bar to place it below the language drop-down.

Other info:

Before:

report-options-bar-before

language-drop-down-before

After:

report-options-bar-after

language-drop-down-after

Thanks for submitting a pull request!
Please make sure you follow our code_of_conduct.md and our contributing guidelines contributing.md

@jgadsden jgadsden self-requested a review April 12, 2024 05:56
@jgadsden jgadsden added bug Something isn't working version-2.3 labels Apr 12, 2024
Copy link
Collaborator

@jgadsden jgadsden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a good improvement, thanks @michaelgrahamevans

@jgadsden jgadsden merged commit e297988 into OWASP:main Apr 12, 2024
@michaelgrahamevans michaelgrahamevans deleted the stop-report-options-moving branch April 12, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working version-2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants