Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation: Vue I18n English Localization to Malay (MS) #925

Merged
merged 9 commits into from
Mar 20, 2024

Conversation

teguh02
Copy link
Collaborator

@teguh02 teguh02 commented Mar 20, 2024

Summary: Translated Vue I18n English language code to Malay (MS).

Description for the changelog: Translated to Malay (MS).

Other info:

The translation process involved meticulous attention to detail to ensure the accuracy and fidelity of the Malay (MS) equivalents to the original English strings. Every effort was made to maintain consistency and coherence throughout the translation process.
Careful consideration was given to cultural nuances and linguistic conventions specific to Malay (MS), ensuring that the translated content aligns seamlessly with the language's idiosyncrasies and user expectations.
This initiative underscores our commitment to inclusivity and user-centric design, as we strive to accommodate diverse linguistic preferences and facilitate a more immersive and personalized user experience.
Contributors are encouraged to review the changes and provide feedback or suggestions for further refinement, as we continually strive to optimize and enrich the language support within our application.

@teguh02
Copy link
Collaborator Author

teguh02 commented Mar 20, 2024

Hi @jgadsden
I was request a pull request again for malay language localization, i was edited all of files same as in Bahasa Indonesia localization pull request here #923 i hope you will review this my new pull request.

Thanks

Copy link
Collaborator

@jgadsden jgadsden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks again for this @teguh02 , it is good to have this translation
I forgot to point you to another change required, it is 'getLanguageName(locale)' line 38 of 'td.vue/src/components/LocaleSelect.vue'
Could the languages be added to this function, both for Malay and Bahasa Indonesia ?

td.vue/src/desktop/menu.js Outdated Show resolved Hide resolved
td.vue/src/desktop/menu.js Outdated Show resolved Hide resolved
td.vue/src/i18n/index.js Outdated Show resolved Hide resolved
td.vue/src/i18n/index.js Outdated Show resolved Hide resolved
td.vue/tests/unit/desktop/menu.spec.js Outdated Show resolved Hide resolved
@teguh02
Copy link
Collaborator Author

teguh02 commented Mar 20, 2024

Hi @jgadsden
I was finished your revision sir, from alphabeticaly the language code and add a code in td.vue/src/components/LocaleSelect.vue
Please check it again later

Thanks Sir

Copy link
Collaborator

@jgadsden jgadsden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you again for this translation @teguh02
I will go ahead and merge it in, and I have also sent you permissions if you would like to accept

@jgadsden jgadsden merged commit a8c40a0 into OWASP:main Mar 20, 2024
@teguh02
Copy link
Collaborator Author

teguh02 commented Mar 20, 2024

thank you again for this translation @teguh02 I will go ahead and merge it in, and I have also sent you permissions if you would like to accept

Hi @jgadsden
Thanks for your invitation, in the future i will try to improve this threat dragon application sir :)

@jgadsden jgadsden mentioned this pull request May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants