-
-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Also build for arm64 #914
Also build for arm64 #914
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
superb, many thanks @jksolbakken
The build fails because of missing secrets for login to Docker Hub. Maybe remove the login step and do not push from the PR workflow? |
possible - although the e2e and zap stages may fail if this is done? Looking at it again the workflow should be changed anyway to cache the docker image so that e2e and zap work OK |
I will update this PR to run the build step before the login for PRs. That way we can determine if the image build itself works without the need for elevated privs. The other steps should work as before when you merge. Secrets are not available if the workflow was caused by an external PR. |
No, wait that won't work. I'll come up with a solution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks agin @jksolbakken , and will go ahead and merge
Summary:
Builds Docker images also for ARM. Improves developer experience on newer Macs with ARM CPU (Mx)
Adds necessary changes to the affected GitHub workflows
Description for the changelog:
add build for arm64 docker image in GitHub workflows
Other info:
The extra build time should be bearable, if not the builds for each arch can be run in parallel using a matrix.