Creation of threats made consistent #910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(bug title is not updated with number after creation without saving) (changes should not be preserved when retained threat next displayed)
jgadsden
changed the title
jgadsden
requested changes
Mar 13, 2024
There was a problem hiding this comment.
This is much appreciated @mohamedselbohy
The close window action on a newly created threat does not quite do the correct thing: when the threat is reopened the Remove button should not be displayed: the Delete and Cancel buttons should be displayed instead, along with th existing prompt if the threat is deleted
|
I have updated the issue #899 for the new desired behavior |
…define creation of threats vs. editing threats
jgadsden
approved these changes
Mar 15, 2024
There was a problem hiding this comment.
many thanks @mohamedselbohy , this is a really useful pull request that sorts out the inconsistent behavior of the threat creation
Much appreciated, please go ahead with the merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the following issues:
How does the addressed issues function now:
now the number of the threat is added when it's created and the content of the threat in the cell is not changed unless saved so the unsaved changes are not retained when the threat is going to get edited again
Fixes some points addressed in #899
Closes #899
Closes #889