-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.1 #124
base: 2.0
Are you sure you want to change the base?
2.1 #124
Conversation
PHP 8's enforcement of the rule that optional parameters cannot precede required parameters in function/method signatures
Fix PHP 8's enforcement of the rule that optional parameters cannot precede required parameters in function/method signatures.
How does this fix for PHP 8? Seems like you just reordered args into the functions. |
|
Was this the only change that was needed to make this PHP 8 compatible? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be $res = $this->{$this->type()}->descendantsConditional("ID=?", false, $ID);
I am using the package in Php 8 (8.0.28 and 8.0.30) and the source is working fine. In Php 8 optional arguments ($AbsoluteDepths=false,$ConditionString) should be after necessary arguments. Thats the reason why most of your forks (i checked about 20) are doing it this way. I really recommand to accept th PR after changing: $res = $this->{$this->type()}->descendantsConditional("ID=?", false, $ID); |
Fixes for PHP 8