Added function to get all users with specific permission #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VyacheslavDolya
suggested changes
Dec 21, 2017
| function users($Permission) | ||
| { | ||
| if (!is_numeric($Permission)) $Permission = $this->returnId($Permission); | ||
| $Res = Jf::sql ("SELECT DISTINCT(UserID) FROM {$this->tablePrefix()}permissions INNER JOIN {$this->tablePrefix()}rolepermissions ON {$this->tablePrefix()}permissions.ID = {$this->tablePrefix()}rolepermissions.PermissionID INNER JOIN {$this->tablePrefix()}roles ON {$this->tablePrefix()}rolepermissions.RoleID = {$this->tablePrefix()}roles.`ID` INNER JOIN {$this->tablePrefix()}userroles ON {$this->tablePrefix()}roles.`ID` = {$this->tablePrefix()}userroles.RoleID WHERE {$this->tablePrefix()}permissions.`ID` = ?", $Permission); |
There was a problem hiding this comment.
| * | ||
| * @param integer $Permission | ||
| * ID | ||
| * @return Array 1D or null |
| */ | ||
| function users($Permission) | ||
| { | ||
| if (!is_numeric($Permission)) $Permission = $this->returnId($Permission); |
There was a problem hiding this comment.
if (!is_int($PermissionId)) {
throw new InvalidArgumentException("`$PermissionId` should be type of integer")
}
There was a problem hiding this comment.
agree. this check can be performed after permission string is resolved into id
| * ID | ||
| * @return Array 1D or null | ||
| */ | ||
| function users($Permission) |
There was a problem hiding this comment.
function getUserIdsByPermissionId($PermissionId)
There was a problem hiding this comment.
this is not the way other functions in a library named
There was a problem hiding this comment.
that's clear function name, belongs to standard naming
| /** | ||
| * Returns all users with a permission | ||
| * | ||
| * @param integer $Permission |
There was a problem hiding this comment.
It gets string or id as parameter.
| if (is_array ( $Res )) | ||
| { | ||
| $out = array (); | ||
| foreach ( $Res as $R ) |
| $out = array (); | ||
| foreach ( $Res as $R ) | ||
| $out [] = $R ['UserID']; | ||
| return $out; |
| { | ||
| $out = array (); | ||
| foreach ( $Res as $R ) | ||
| $out [] = $R ['UserID']; |
There was a problem hiding this comment.
$answer[] = (int) $user['UserID'];
| $out [] = $R ['UserID']; | ||
| return $out; | ||
| } | ||
| else |
| return $out; | ||
| } | ||
| else | ||
| return null; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.