-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sensitive Data Leaked via Screenshots (by @guardsquare) #3112
Open
serek8
wants to merge
9
commits into
OWASP:master
Choose a base branch
from
serek8:issue-2695-fix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+241
−8
Open
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
49a76c9
Add a weakness page
serek8 c4b0d95
Add a test page
serek8 4623df4
Add a demo
serek8 7f5c7ef
Fix title
serek8 8ace5ad
Add a test for iOS
serek8 fe1ba54
Add new refs for the weakness
serek8 5ab405d
Update test ID
serek8 c629de3
Add demo
serek8 2e536fc
Fix rules path
serek8 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add a test page
commit c4b0d95a0161cd2ad0fb3327f468d2de2c77f5c7
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
--- | ||
title: Sensitive Data Leaked via Screenshots | ||
platform: android | ||
id: MASTG-TEST-0216 | ||
type: [static] | ||
weakness: MASWE-0055 | ||
--- | ||
|
||
## Overview | ||
|
||
This test verifies whether an app uses APIs to prevent or detect screen capturing. While prevention is preferable to detection, this test ensures that the app is aware of potential screenshot issues. On Android, several APIs allow developers to detect when screenshots are taken, such as: | ||
|
||
- [FLAG_SECURE](https://developer.android.com/security/fraud-prevention/activities#flag_secure) - prevents screen recording | ||
- [DETECT_SCREEN_CAPTURE](https://developer.android.com/about/versions/14/features/screenshot-detection#implementation) - detects when a screenshot is taken | ||
|
||
## Steps | ||
|
||
1. Run a static analysis tool, such as @MASTG-TOOL-0110, on the code to identify instances of relevant API usage. | ||
|
||
## Observation | ||
|
||
The output should include a list of locations where the relevant APIs are used. | ||
|
||
## Evaluation | ||
|
||
The test case fails if you cannot find the relevant APIs on the Activities that display sensitive data. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a more specific title and inline with other tests.
Titles get more specific as we go from weakness > test > demo