Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port MASTG test 0038 (by @guardsquare) #3044

Merged
merged 8 commits into from
Nov 7, 2024
Merged

Port MASTG test 0038 (by @guardsquare) #3044

merged 8 commits into from
Nov 7, 2024

Conversation

titze
Copy link
Collaborator

@titze titze commented Nov 6, 2024

Thank you for submitting a Pull Request to the OWASP MASTG. Please make sure that:

  • Your contribution is written in the 2nd person (e.g. you)
  • Your contribution is written in an active present form for as much as possible.
  • You have made sure that the reference section is up to date (e.g. please add sources you have used, make sure that the references to MITRE/MASVS/etc. are up to date)
  • Your contribution has proper formatted markdown and/or code
  • Any references to website have been formatted as [TEXT](URL “NAME”)
  • You verified/tested the effectiveness of your contribution (e.g.: is the code really an effective remediation? Please verify it works!)

If your PR is related to an issue. Please end your PR test with the following line:
This PR closes #3015.

I did not transfer the part that shows the content of the certificate, as this does not seem related to the test case.

@cpholguera cpholguera merged commit 90e3b81 into OWASP:master Nov 7, 2024
5 of 6 checks passed
@titze titze deleted the port-MASTG-TEST-0038 branch November 26, 2024 07:58
serek8 pushed a commit to serek8/owasp-mstg that referenced this pull request Jan 2, 2025
@titze @cpholguera @serek8
Port MASTG test 0038 (by @Guardsquare) (OWASP#3044)
25aa2b6 
* Port MASTG test 0038

* fix tool ID

* add new technique

* update tool

* fix title, update to use TECH and add more evaluation

* add new test for key size

* fix markdown, update tool execution command

* Apply suggestions from code review

Co-authored-by: Carlos Holguera <[email protected]>

---------

Co-authored-by: Carlos Holguera <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpholguera cpholguera cpholguera approved these changes

Assignees
No one assigned
Labels
Android fundamentals
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MASTG v1->v2 MASTG-TEST-0038: Making Sure that the App is Properly Signed (android)
2 participants
@titze @cpholguera