Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add inAttribute and change parameter order #267

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yangbongsoo
Copy link
Contributor

First of all, thank you for continuously doing the version up.

  1. Added comment for newly added inAttribute in appendDecodedEntity method.
  2. Like the order of the appendDecodedEntity method parameter, I modified it because I thought it would be more natural to have the html parameter come first. Since the inAttribute parameter is used first inside mayComplete method, it can be said that it was declared first, so if you say no, I will roll back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant