Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow colspan attribute on td and th elements #196

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/main/java/org/owasp/html/Sanitizers.java
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ public final class Sanitizers {
.onElements("table", "tr", "td", "th",
"colgroup", "col",
"thead", "tbody", "tfoot")
.allowAttributes("colspan").onElements("td", "th)
.allowTextIn("table") // WIDGY
.toFactory();

Expand Down
18 changes: 18 additions & 0 deletions src/test/java/org/owasp/html/SanitizersTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -434,6 +434,24 @@ public static final void testStyleTagInTable() {
pf.sanitize(input));
}

@Test
public static final void testColspanAttributeInTable() {
String input = ""
+ "<table>"
+ "<tr><th colspan=\"2\">Foo</th></tr>"
+ "<tr><td colspan=\"2\">Bar</td></tr>"
+ "</table>";
PolicyFactory pf = Sanitizers.BLOCKS
.and(Sanitizers.FORMATTING)
.and(Sanitizers.TABLES);
assertEquals(
"<table><tbody>"
+ "<tr><th colspan=\"2\">Foo</th></tr>"
+ "<tr><td colspan=\"2\">Bar</td></tr>"
+ "</tbody></table>",
pf.sanitize(input));
}

static int fac(int n) {
int ifac = 1;
for (int i = 1; i <= n; ++i) {
Expand Down