Update Argon2 and scrypt work factors #1073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sc00bz
requested review from
kwwall,
mackowski,
jmanico and
szh
as code owners
This was referenced Jan 24, 2023
|
What data are these recommendations based on? Thanks |
|
It's based off the RX 7900 XTX's memory bandwidth. So these are the maximum theoretical minimum settings for <10 kH/s/GPU. The RX 7900 XTX was picked because it has the highest bandwidth (960 GB/s) for a reasonably priced GPU (<$1000). I'd base it off benchmarks but I don't have access to a bunch of different GPUs for testing. Also GPU cracking software needs some work for Argon2 and scrypt. Both algorithms have an internal parallelism that Hashcat isn't taking advantage. And benchmarks with other software are hard to find or with old GPUs. Also the benchmarks with Hashcat for scrypt are for specific low settings. |
stringhandler
pushed a commit
to tari-project/tari
that referenced
this pull request
Jan 30, 2023
Description --- Updates `Argon2` parameters. Closes [issue 5139](#5139). Motivation and Context --- A recent [update](OWASP/CheatSheetSeries#1073) to the [OWASP recommendations](https://cheatsheetseries.owasp.org/cheatsheets/Password_Storage_Cheat_Sheet.html#argon2id) for `Argon2` password-based key derivation means the codebase is out of date. This PR updates all `Argon2` parameters to meet this standard. While there are no particularly concerning risks to users with the older standard, it's a matter of good practice to keep these updated where feasible. Note that this PR does not introduce any kind of key migration, so this change is... How Has This Been Tested? --- Existing tests pass. BREAKING CHANGE: Renders all previous `Argon2`-derived keys invalid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a Pull Request (PR) to the Cheat Sheet Series.
Please make sure that for your contribution:
If your PR is related to an issue, please finish your PR text with the following line:
This PR is kind of related to issue #1043
Thank you again for your contribution 😃